Fix handling of schemas with .transform in them
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
despairblue
reviewed
Dec 27, 2024
This was referenced Dec 27, 2024
|
I added some suggestions here: netroy#1 |
sam-goodwin
approved these changes
Dec 27, 2024
| ? z.output<T> | ||
| : never; | ||
|
|
||
| export type input<T> = T extends new (...args: any[]) => infer R |
There was a problem hiding this comment.
Curious, what was the reason to separate out into input/output?
There was a problem hiding this comment.
The constructors argument should be of the type z.input<schema> and the instance type of the class should be z.output<schema> with z.input being the type of what should go into z.parse and z.output is the type it returns if parsed successfully which includes all transforms which can change the type.
I could try to parameterize this type and have z.input and z.output passed in as a type parameter to reduce the duplication. Should I give that a try?
I hope I got the question right, if not let me know :)
|
Thanks @netroy and @despairblue, the fix is released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31