Improvements to UN1CA #279
Open
+192
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…way, help, dependencycheck: apt, venv
Fede2782
reviewed
Dec 24, 2024
| libpcre2-dev ccache npm | ||
| ) | ||
|
|
||
| echo "Checking dependencies..." |
There was a problem hiding this comment.
This way you are considering that only Debian-based distros will be used for ROM building. You should adapt this logic to check if distro is Debian based. Possibly some packages are also available only in certain distros/releases.
Openjdk 11 is the minimum required version. And if I remember correctly also unzip package has to be installed.
| echo -e "Available cmds:" | ||
| for script in "scripts"/*.sh; do | ||
| CMD_NAME=$(basename "$script" .sh) | ||
| HELP_LINES=$(grep "^# CMD_HELP" "$script" | sed 's/^# CMD_HELP[[:space:]]*//') |
There was a problem hiding this comment.
Just a thought of mine, I think creating a function inside each script which prints the help is a bit better than this actual implementation.
Fede2782
reviewed
Dec 28, 2024
| @@ -32,14 +94,30 @@ TOOLS_DIR="$OUT_DIR/tools/bin" | |||
|
|
|||
| PATH="$TOOLS_DIR:$PATH" | |||
|
|
|||
| run_cmd() | |||
There was a problem hiding this comment.
This breaks workflows. You should change them too.
salvogiangri
force-pushed
the
fourteen
branch
from
2329b71 to
96631e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, here i am doing a Pull request to add improvements to UN1CA!
Following things have been improved:
Instead of the unclear "run_cmd" command we now use "unica"
The buildenv.sh also shows how you can look at the commands.
It clones submodules, installs dependencies, creates a venv (for the new downloader) and builds all dependencies. also a nice menu that shows all the devices in the target folder and is selectable by entering a number.
New Downloader using Python (old one isnt removed yet!) (Thanks to anyone that contributed to the fork from @ananjaser1211!!)
It downloads faster in my experience.