feat: add headed mode and custom display support to CLI#3
Open
arielfrja wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for running TBP in headed mode (visible window) and specifying a custom X11 display.
Key changes:
--headedflag totbp startto skip internal Xvfb/Openbox and use an existing display.--displayflag totbp startto specify the target X11 display (e.g.,:0).xdpyinfoto ensure the requested display is reachable, preventing the daemon from hanging if the X server is missing.Daemonclass to propagate these settings to thePilotinstance.This allows TBP to run directly within active XFCE or Termux:X11 sessions.