-
Notifications
You must be signed in to change notification settings - Fork 422
test(wtr): run in multiple browsers and with API_VERSION=66 #5533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wjhsf
wants to merge
18
commits into
master
Choose a base branch
from
wjh/wtr-keep-on-enving
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not convinced this is the right place to do it
wjhsf
commented
Oct 7, 2025
FAIL: packages/@lwc/engine-dom/dist/index.js: 24.79KB > 24.79KB RUDE
installing in package break nucleus
/nucleus ingore --reason "PR isn't ready and I want to watch CI" |
❌ Error Parsing CommandUnknown arguments: reason, ingore
|
/nucleus ignore --reason "PR isn't ready and I want to watch CI" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds a CI run of the tests with
API_VERSION=66
and updates the config to run in chrome, firefox, and safari. It also (hopefully) connects to saucelabs when run in CI. If theLEGACY_BROWSERS
var is set in CI, then it runs slightly old chrome and safari (not that legacy, imo 🤷).Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item