Skip to content

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Oct 7, 2025

Details

This PR adds a CI run of the tests with API_VERSION=66 and updates the config to run in chrome, firefox, and safari. It also (hopefully) connects to saucelabs when run in CI. If the LEGACY_BROWSERS var is set in CI, then it runs slightly old chrome and safari (not that legacy, imo 🤷).

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner October 7, 2025 18:54
I'm not convinced this is the right place to do it
@wjhsf
Copy link
Contributor Author

wjhsf commented Oct 9, 2025

/nucleus ingore --reason "PR isn't ready and I want to watch CI"

Copy link
Contributor

❌ Error Parsing Command

Unknown arguments: reason, ingore

/nucleus <command>

Commands:
  /nucleus deploy                           Perform deploy
  /nucleus help                             Display usage information
  /nucleus ignore                           Ignore test failures
  /nucleus ping                             Ping Nucleus
  /nucleus release                          Perform release
  /nucleus reset-auto-increment             Reset auto-increment value for
  [incrementValue]                          project
  /nucleus skip-dep-update                  Opt-out from the upstream dependency
                                            update
  /nucleus skip-deployment                  Mark deployment as skipped for the
                                            workflow associated with this PR
  /nucleus start                            Start the Nucleus workflow
                                            associated with this pull-request.
  /nucleus stop                             Stops the workflow associated with
                                            this PR.
  /nucleus test                             Build project and execute tests.
                                            This command may be executed to
                                            re-run the testing stage.
  /nucleus update-downstream-deps           Update downstream dependents
  /nucleus bump-version [version]           Bump version

Options:
  --help  Show help                                                    [boolean]

Examples:
  /nucleus release 1.2.0  Release version 1.2.0

Unknown arguments: reason, ingore

@wjhsf
Copy link
Contributor Author

wjhsf commented Oct 9, 2025

/nucleus ignore --reason "PR isn't ready and I want to watch CI"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant