Skip to content

fix(release): oops shell scripts are relative to cwd #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(release): oops shell scripts are relative to cwd #5368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d97b53
fix(release): oops shell scripts are relative to cwd
wjhsf Apr 14, 2025
fda5223
Merge branch 'master' into wjh/fix-release
wjhsf May 7, 2025
262db5a
fix(release): properly handle semver release types
wjhsf May 7, 2025
09feef8
Merge branch 'master' into wjh/fix-release
wjhsf May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/release/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ if which gh >/dev/null; then
git branch -D "$BRANCH"

# Wait for CI to complete
./wait-for-pr.sh "$BRANCH"
. "$(dirname "$0")/wait-for-pr.sh" "$BRANCH"
if ! gh pr checks --fail-fast --watch; then
echo 'CI failed. Cannot continue with release.'
gh pr view "$BRANCH" --web
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ if which gh 2>/dev/null 1>/dev/null; then
git switch "$BASE_BRANCH"
git branch -D "$BRANCH"

./wait-for-pr.sh "$BRANCH"
. "$(dirname "$0")/wait-for-pr.sh" "$BRANCH"
while [ "$(gh pr view "$BRANCH" --json state -q .state)" != 'MERGED' ]; do
sleep 3 # Wait for GitHub to auto-merge the PR
done
Expand Down