Upgrade to Net 8 #86
Merged
Upgrade to Net 8 #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
salem84
commented
Mar 14, 2025
salem84
commented
- Updated framework and packages
- Changed simpleicons
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to .NET 8 while updating package versions and refreshing icon references.
- Updated README badges and endpoint parameter descriptions
- Upgraded GitHub Actions steps (checkout, GitVersion, setup-dotnet, setup-java, webapps-deploy, super-linter)
- Modified sample page icon usage for improved consistency
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated badge images and revised endpoint query parameter description for icons |
| .github/workflows/build-publish.yml | Upgraded several action versions and updated .NET version configuration |
| .github/workflows/build.yml | Upgraded actions and updated .NET version |
| .github/workflows/deploy-demo-site.yml | Updated Azure deployment action version and .NET version configuration |
| .github/workflows/linter.yml | Upgraded checkout and super-linter versions |
| samples/Basic/Pages/Index.cshtml | Changed the icon parameter value for the runtime identifier badge |
Comments suppressed due to low confidence (1)
README.md:130
- The icon example in the querystring description has been changed to 'simpleicons__linux', which is inconsistent with the icon used in the sample page ('simpleicons__dotnet'). Please verify and align the icon reference across documentation and sample usage.
* `icon`: the source type and slug for the icon separated by two underscore characters (`__`) such as `simpleicons__linux`. In this version only [Simple Icons](https://simpleicons.org/) type is supported; you can find a list of slugs [here](https://github.com/simple-icons/simple-icons/blob/develop/slugs.md). Icon color is always white.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.