Skip to content

Testbranch1beta_RS#3

Open
RashmiG5 wants to merge 2 commits into
saketkc:masterfrom
RashmiG5:testbranch1beta
Open

Testbranch1beta_RS#3
RashmiG5 wants to merge 2 commits into
saketkc:masterfrom
RashmiG5:testbranch1beta

Conversation

@RashmiG5

@RashmiG5 RashmiG5 commented Sep 17, 2025

Copy link
Copy Markdown

first pull request.

Summary by Sourcery

Add an extended parameter set for interventions and disease dynamics, update the plotting output path and tune key transmission parameters

New Features:

  • Introduce data/parameters3.yaml with intervention parameters, contact/mixing rates, and disease progression probabilities

Enhancements:

  • Update default plot_results save path and docstring
  • Adjust base model transmission parameters (beta and sigma) in data/parameters.yaml

@sourcery-ai

sourcery-ai Bot commented Sep 17, 2025

Copy link
Copy Markdown

Reviewer's Guide

Updated visualization method path and docstring, adjusted core transmission parameters, and introduced a new extended parameters file with intervention and contact settings.

Entity relationship diagram for updated and new parameters files

erDiagram
    PARAMETERS_YAML {
        beta float
        sigma float
        gamma float
        mu float
    }
    PARAMETERS3_YAML {
        beta float
        sigma float
        gamma float
        mu float
        treatment_rate float
        vaccine_efficacy float
        contact_rate int
        prob_fast_progression float
        prob_reactivation float
    }
    PARAMETERS_YAML ||--|| PARAMETERS3_YAML : "extends"
Loading

Class diagram for updated plot_results method in tb_model.py

classDiagram
    class TBModel {
        +run_simulation(years)
        +plot_results(save_path)
        results
    }
    TBModel : plot_results(save_path)
    TBModel : results
Loading

File-Level Changes

Change Details Files
Updated plot_results default path and documentation
  • Changed default save_path to './results/tb_model_output.png'
  • Extended docstring with usage note and save path
  • Inserted a stray 'save.path' line
src/tb_model.py
Adjusted baseline transmission parameters
  • Increased beta from 0.05 to 0.125
  • Decreased sigma from 0.0002 to 0.0001
data/parameters.yaml
Added a new parameters file with intervention and contact settings
  • Created parameters3.yaml with model_parameters section
  • Defined treatment_rate, vaccine_efficacy, contact_rate, and progression probabilities
data/parameters3.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Clean up the plot_results docstring to remove the stray "save.path" line and clearly document the save_path parameter.
  • If you’re adding parameters3.yaml, either integrate it into your config‐loading logic or remove it to avoid shipping an unused file.
  • Avoid hardcoding './results/' in plot_results; consider using pathlib or passing a configurable output directory instead.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Clean up the plot_results docstring to remove the stray "save.path" line and clearly document the save_path parameter.
- If you’re adding parameters3.yaml, either integrate it into your config‐loading logic or remove it to avoid shipping an unused file.
- Avoid hardcoding './results/' in plot_results; consider using pathlib or passing a configurable output directory instead.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant