Testbranch1beta_RS#3
Open
RashmiG5 wants to merge 2 commits into
Open
Conversation
Reviewer's GuideUpdated visualization method path and docstring, adjusted core transmission parameters, and introduced a new extended parameters file with intervention and contact settings. Entity relationship diagram for updated and new parameters fileserDiagram
PARAMETERS_YAML {
beta float
sigma float
gamma float
mu float
}
PARAMETERS3_YAML {
beta float
sigma float
gamma float
mu float
treatment_rate float
vaccine_efficacy float
contact_rate int
prob_fast_progression float
prob_reactivation float
}
PARAMETERS_YAML ||--|| PARAMETERS3_YAML : "extends"
Class diagram for updated plot_results method in tb_model.pyclassDiagram
class TBModel {
+run_simulation(years)
+plot_results(save_path)
results
}
TBModel : plot_results(save_path)
TBModel : results
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Clean up the plot_results docstring to remove the stray "save.path" line and clearly document the save_path parameter.
- If you’re adding parameters3.yaml, either integrate it into your config‐loading logic or remove it to avoid shipping an unused file.
- Avoid hardcoding './results/' in plot_results; consider using pathlib or passing a configurable output directory instead.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Clean up the plot_results docstring to remove the stray "save.path" line and clearly document the save_path parameter.
- If you’re adding parameters3.yaml, either integrate it into your config‐loading logic or remove it to avoid shipping an unused file.
- Avoid hardcoding './results/' in plot_results; consider using pathlib or passing a configurable output directory instead.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first pull request.
Summary by Sourcery
Add an extended parameter set for interventions and disease dynamics, update the plotting output path and tune key transmission parameters
New Features:
Enhancements: