Stop UrlAnnotation and LinkAnnotations from being stripped #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanstern
changed the title
saket
reviewed
Aug 2, 2024
| text.getUrlAnnotations(start = 0, end = text.length).fastForEach { | ||
| addUrlAnnotation(it.item, it.start, it.end) | ||
| } | ||
| text.getLinkAnnotations(start = 0, end = text.length).fastForEach { range -> |
There was a problem hiding this comment.
TIL about link annotations. Are they the reason why a beta version of compose is needed?
There was a problem hiding this comment.
Ya, they were added in the 1.7.0 beta. https://developer.android.com/reference/kotlin/androidx/compose/ui/text/LinkAnnotation
There was a problem hiding this comment.
I'll probably have to split the changes and make two releases, one for 1.6.x and one for 1.7.x-beta
saket
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last release, it looks like a few new annotations have been added for linkified text. I bumped this to latest compose beta in order to add support for
UrlAnnotationandLinkAnnotation.