SAK-50787 Portal footer on Commons page: build info no pop-up #13140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s pop-up Existing popover safe version of initializing popovers
ottenhoff
approved these changes
Dec 28, 2024
|
Please see #13141 to fix this build issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing popover safe version of initializing popovers. This
getOrCreateInstancemethod was added in Bootstrap 5.Alternatively I was going to check
if (!bootstrap.Popover.getInstance(t)) { ... }But this worked and seemed more straightforward. I tested on some of the popups in commons as well as the information popup.