Skip to content

Conversation

@nephros
Copy link
Contributor

@nephros nephros commented Sep 29, 2024

Co-authored-by: sebix

Initial Version, from the Prague Sailathon 2024

@rainemak rainemak requested a review from keto October 3, 2024 07:30
Copy link
Member

@keto keto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some initial comments. (sorry for not looking into this earlier)

In general a really good start. There are few things that are maybe not specific to OBS and could go into documents about packaging and packaging formats .

You may want to look at its [source code](https://github.com/MeeGoIntegration/obs-service-tar-git) detailed information about `tar_git`.


#### Understanding version mangling performed by `tar_git`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section about how the Version and Release (not revision) in spec are set by OBS and tar_git source service is a bit off in many minor ways. Need to think a bit how to formulate it correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it a bit, please read again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants