Skip to content

Conversation

@nephros
Copy link
Contributor

@nephros nephros commented Jan 31, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2024

CLA assistant check
All committers have signed the CLA.

@rainemak rainemak requested review from Tomin1 and spiiroin February 5, 2024 13:00
Copy link
Member

@Tomin1 Tomin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about things that you might not be aware of and a question about usefulness of NotShowIn=X-MeeGo. I didn't check if that D-Bus information is correct, but it sounds sane, although anything with Maemo sounds like a super old relic 😂 and I'd personally rather not advertise those.

@nephros
Copy link
Contributor Author

nephros commented Feb 7, 2024

anything with Maemo sounds like a super old relic 😂 and I'd personally rather not advertise those.

For me it's about reducing confusion.

Sailjail-related documentation being rather fragmented, it's really hard to piece everything together, which was one of the main motivations for this PR.

You can see devs wondering on how to do DBus-related things often on the Forums and other places.

But it's your call, we can drop it from this.

This is mainly useful for registering a MIME Type launchers.

In case of multi-platform apps sharing the same .desktop file, app developers
can use _NotShowIn=X-MeeGo_, to hide the launcher only in Sailfish OS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, think we could avoid meego references at this point. If needed it should be easy to add sailfish specific NotShownIn option, but then again is there actual need to have this? Unlike on linux desktop where one can change the desktop environment the sailfish apps are executed in more controlled environment. If a .desktop is not wanted to be visible as launcher, why include it in the rpm at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants