allow choosing between libgcrypt, gnutls or embedded MD5 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
force-pushed
the
without-libgcrypt
branch
2 times, most recently
from
b525506 to
31ec184
Compare
libgcrypt is a relatively large dependency that is used only for the sake of computing MD5 in the CHAP authentication protocol. Allow distributions to disable it forcibly and rely on the embedded MD5 implementation. Signed-off-by: Paolo Bonzini <[email protected]>
Implement a more generic wrapper API for message digests, so that it is easier to also include gnutls as an option. Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
without-libgcrypt
branch
from
31ec184 to
2215928
Compare
Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
without-libgcrypt
branch
from
2215928 to
35fec3e
Compare
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgcrypt is a relatively large dependency that is used only for the sake of computing MD5 in the CHAP authentication protocol. Some distributions may want to disable it forcibly and rely on the embedded MD5 implementation.
On the other hand, other distributions may want to standardize on as few crypto libraries as possible, and to that end it makes sense to support libgnutls which has a superset of the libgcrypt functionality. So add support for that one as well.