Skip to content

Removed the _already_issued variable logic #39855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Krishnadubey1008
Copy link
Contributor

this PR fixes #39811
modified experimental_warning in wrapper function to respect the warnings filter settings instead of using _already_issued

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Apr 3, 2025

Documentation preview for this PR (built with commit a2d7f49; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor

We need some alternative mechanism to #20601 then. Let's see how…

@tobiasdiez
Copy link
Contributor

Should probably be handled in parallel with #39720 otherwise there will be a lot of (pretty useless) warnings in the docs (see the many test failures).

@user202729
Copy link
Contributor

Should probably be handled in parallel with #39720 otherwise there will be a lot of (pretty useless) warnings in the docs (see the many test failures).

Or we can just modify the doctests.

Actually… each warning only need to be tested that they will be raised once. I don't think it's a large issue though, the same situation is with deprecation warning right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

experimental warning messages are only raised once, ignoring warnings.simplefilter()
3 participants