Correctly passing kwargs in short_vectors #39848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 1a41ce9; changes) is ready! 🎉 |
|
While the fix is correct, the test is incorrect — as you can see there is an identical test above and the behavior appears to be correct before the fix. The reason being the thing is passed as a positional argument and the string I suggest testing by Do add an explanation what you're testing for, link to this pull request. |
|
Documentation build is failing, please fix. |
|
Thanks. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 3, 2025
This fixes the bug in that I tested for. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39848 Reported by: Edgar Costa Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 4, 2025
sagemathgh-39848: Correctly passing kwargs in short_vectors This fixes the bug in that I tested for. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39848 Reported by: Edgar Costa Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 5, 2025
sagemathgh-39848: Correctly passing kwargs in short_vectors This fixes the bug in that I tested for. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39848 Reported by: Edgar Costa Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 7, 2025
sagemathgh-39848: Correctly passing kwargs in short_vectors This fixes the bug in that I tested for. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39848 Reported by: Edgar Costa Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 10, 2025
sagemathgh-39848: Correctly passing kwargs in short_vectors This fixes the bug in that I tested for. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39848 Reported by: Edgar Costa Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug in that I tested for.
📝 Checklist