-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve graph traversal methods #39217
Open
dcoudert
wants to merge
5
commits into
sagemath:develop
Choose a base branch
from
dcoudert:graphs/improve_traversal_methods
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
improve graph traversal methods #39217
dcoudert
wants to merge
5
commits into
sagemath:develop
from
dcoudert:graphs/improve_traversal_methods
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some timings to see the (small) advantage of using the pairing heap data structure. Before sage: G = graphs.PathGraph(4)
sage: %timeit G.maximum_cardinality_search(initial_vertex=0)
9.77 µs ± 16.9 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)
sage: G = graphs.Grid2dGraph(10, 10)
sage: %timeit G.maximum_cardinality_search()
209 µs ± 1.53 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each)
sage: G = graphs.Grid2dGraph(100, 100)
sage: %timeit G.maximum_cardinality_search()
87.2 ms ± 462 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)
sage: G = graphs.CompleteGraph(10)
sage: %timeit G.maximum_cardinality_search()
27 µs ± 85.9 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)
sage: G = graphs.Cell600()
sage: %timeit G.maximum_cardinality_search()
355 µs ± 1.6 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each) With this PR: sage: G = graphs.PathGraph(4)
sage: %timeit G.maximum_cardinality_search(initial_vertex=0)
9.74 µs ± 32.6 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)
sage: G = graphs.Grid2dGraph(10, 10)
sage: %timeit G.maximum_cardinality_search()
206 µs ± 371 ns per loop (mean ± std. dev. of 7 runs, 1,000 loops each)
sage: G = graphs.Grid2dGraph(100, 100)
sage: %timeit G.maximum_cardinality_search()
85.9 ms ± 363 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)
sage: G = graphs.CompleteGraph(10)
sage: %timeit G.maximum_cardinality_search()
25.4 µs ± 36.5 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)
sage: G = graphs.Cell600()
sage: %timeit G.maximum_cardinality_search()
324 µs ± 1.2 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each) |
Documentation preview for this PR (built with commit 438865c; changes) is ready! 🎉 |
tscrim
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #39216, we avoid the conversion to
short_digraph
when the input graph is an instance ofStaticSparseBackend
.Furthermore, we use the new
PairingHeap_of_n_integers
data structure (#39046) instead of apriority_queue
to emulate a max-heap. This is slightly faster this way and cleaner.📝 Checklist
⌛ Dependencies