-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword prec for exponential and logarithm of Drinfeld modules #39214
Conversation
Documentation preview for this PR (built with commit 1fa959b; changes) is ready! 🎉 |
Off topic: Which methods are missing in |
e.g. |
Oh, I missed the possibility of taking out
I actually have code for that, but was too lazy to get it in.
I agree. Maybe we can discuss this at sd128? |
src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
Outdated
Show resolved
Hide resolved
src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
Outdated
Show resolved
Hide resolved
src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Rubey <[email protected]>
Co-authored-by: Martin Rubey <[email protected]>
Co-authored-by: Martin Rubey <[email protected]>
Sure! |
src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
Show resolved
Hide resolved
Once again, it seems that the failed tests are independent to that PR:
@xcaruso, could you merge from |
src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did my review. I only request that you add the latest changes from develop. My comments in the review are only suggestions, and you can freely choose to accept them or not. I'll approve the review either way. The only thing truly missing are the valid automatic tests (which unfortunately do not seem to be your fault's...).
Thank you very much for this lovely and useful PR 💙
src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
Outdated
Show resolved
Hide resolved
src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
Show resolved
Hide resolved
src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
Show resolved
Hide resolved
src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
Show resolved
Hide resolved
…ld_module.py Co-authored-by: Antoine Leudière <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, these failing doctests seem unrelated to our work. Therefore, I approve the PR.
Many thanks to Xavier.
sagemathgh-39214: Add keyword prec for exponential and logarithm of Drinfeld modules Currently, the methods `exponential` and `logarithm` for Drinfeld modules return a `LazyPowerSeriesRing` for which not all methods are available. We add a keyword `prec`. When it is `Infinity` (which is the default), the behavior is unchanged. However, when we pass in a finite number, a classical power series (up to the given precision) is returned. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39214 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Martin Rubey, Xavier Caruso
🍷 |
Currently, the methods
exponential
andlogarithm
for Drinfeld modules return aLazyPowerSeriesRing
for which not all methods are available.We add a keyword
prec
. When it isInfinity
(which is the default), the behavior is unchanged. However, when we pass in a finite number, a classical power series (up to the given precision) is returned.📝 Checklist