-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spyx_tmp()
cleanup.
#39201
Merged
Merged
Fix spyx_tmp()
cleanup.
#39201
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
tempfile.TemporaryDirectory()
works just fine for me, so this comment may not be completely correct (however, it is not cleaned up on exit of the parent process)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm.. so you mean
TemporaryDirectory()
is not cleaning up on program exit in general, or only insage.misc.temporary_file.spyx_tmp()
? What aboutsage.misc.temporary_file.TMP_DIR_FILENAME_BASE
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only on
spyx_tmp()
. TheTMP_DIR_FILENAME_BASE
one is cleaned up correctlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, there seems to be something fragile about using
TemporaryDirectory()
on a local variable that is meant to survive its function. There are no clear rules about when this object will be destroyed (apparently thelambda: d.cleanup()
grabs a reference that stays in the atexit hook, but I'm not sure if the lambda takes a strong reference).I guess the "right" way to acomplish what was intended here might be to store
d
in the global variable, and not justd.name
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expanded the comment to mention that several different behaviors can happen.
@antonio-rojas can you have a look and maybe approve this? We are shipping this in the void linux package for sagemath 10.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm shipping this too and have run the test suite in parallel a few times.