Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added immutable keyword argument to canonical_form function #39196

Closed
wants to merge 1 commit into from

Conversation

kaneki003
Copy link

@kaneki003 kaneki003 commented Dec 23, 2024

Description

-Fixes #39177. Avoiding extra code block for declaring an immutable graph while generating it.
-Added immutable keyword argument to canonical_form function to directly return an immutable canonical label of a given graph.
-Updated the function to handle the immutable argument and return an immutable graph if specified.
-Added tests to verify the functionality of the immutable argument.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not enough. You must also add parameter immutable to method canonical_label in generic_graph.py and ensure that it is also working well when algorithm='sage'.

@kaneki003 kaneki003 deleted the branch sagemath:develop December 29, 2024 16:22
@kaneki003 kaneki003 closed this Dec 29, 2024
@kaneki003 kaneki003 deleted the develop branch December 29, 2024 16:22
@kaneki003 kaneki003 restored the develop branch December 29, 2024 17:48
@kaneki003 kaneki003 deleted the develop branch December 29, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants