Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/ccache: Update to 4.10.2 #39119

Merged
merged 2 commits into from
Dec 22, 2024
Merged

build/pkgs/ccache: Update to 4.10.2 #39119

merged 2 commits into from
Dec 22, 2024

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented Dec 11, 2024

I also modified sdh_cmake slightly, because inputting . and .. together issued a warning.

Resolves #35872.

@gmou3 gmou3 changed the title Update ccache to 4.10.2 build/pkgs/ccache: Update to 4.10.2 Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Documentation preview for this PR (built with commit 02273ef; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 15, 2024

I tested the branch (and the new ccache) on a mac. Did you test it on any linux?

@gmou3
Copy link
Contributor Author

gmou3 commented Dec 15, 2024

Yes, seems to work fine.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. LGTM.

Thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 15, 2024
    
I also modified `sdh_cmake` slightly, because inputting `.` and `..`
together issued a warning.

Resolves sagemath#35872.
    
URL: sagemath#39119
Reported by: gmou3
Reviewer(s): gmou3, Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 19, 2024
    
I also modified `sdh_cmake` slightly, because inputting `.` and `..`
together issued a warning.

Resolves sagemath#35872.
    
URL: sagemath#39119
Reported by: gmou3
Reviewer(s): gmou3, Kwankyu Lee
@vbraun vbraun merged commit 47df08e into sagemath:develop Dec 22, 2024
15 of 44 checks passed
@gmou3 gmou3 deleted the ccache branch December 25, 2024 16:35
@enriqueartal
Copy link
Contributor

I had an issue in Fedora 41, ccache installation did not work having some issue with Xxhash. It worked after installing system package xxhash-devel; should this dependency appeared somewhere? On the other side system package ccache is installed and a fedora.txt exists in the corresponding distro folder, but it is ignored.

@kwankyu
Copy link
Collaborator

kwankyu commented Jan 1, 2025

See https://groups.google.com/g/sage-devel/c/ZZIvoEHm5hg for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants