build/pkgs/planarity/spkg-configure.m4: update header check #39111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the ./configure test for libplanarity, we should be testing for planarity/graph.h instead of planarity/planarity.h: 1. graph.h is what we actually use in src/sage/graphs/planarity.pyx, 2. planarity.h is going away in a future version. cf. graph-algorithms/edge-addition-planarity-suite#125
|
Documentation preview for this PR (built with commit ea0f811; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 11, 2024
…er check In the `./configure` test for libplanarity, we should be testing for `planarity/graph.h` instead of `planarity/planarity.h`: 1. `graph.h` is what we actually use in `src/sage/graphs/planarity.pyx`, 2. `planarity.h` is going away in a future version. cf. https://github.com/graph-algorithms/edge-addition-planarity- suite/pull/125 URL: sagemath#39111 Reported by: Michael Orlitzky Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 12, 2024
…er check
In the `./configure` test for libplanarity, we should be testing for
`planarity/graph.h` instead of `planarity/planarity.h`:
1. `graph.h` is what we actually use in
`src/sage/graphs/planarity.pyx`,
2. `planarity.h` is going away in a future version.
cf. https://github.com/graph-algorithms/edge-addition-planarity-
suite/pull/125
URL: sagemath#39111
Reported by: Michael Orlitzky
Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
./configuretest for libplanarity, we should be testing forplanarity/graph.hinstead ofplanarity/planarity.h:graph.his what we actually use insrc/sage/graphs/planarity.pyx,planarity.his going away in a future version.cf. graph-algorithms/edge-addition-planarity-suite#125