Don't (mis)use prec_words_to_bits()
#38908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words.
|
See also: sagemath/cypari2#166 (comment) |
|
Already tested as part of #38749 |
videlec
approved these changes
Nov 2, 2024
|
Documentation preview for this PR (built with commit e29692d; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 5, 2024
sagemathgh-38908: Don't (mis)use `prec_words_to_bits()` We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 6, 2024
sagemathgh-38908: Don't (mis)use `prec_words_to_bits()` We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 7, 2024
sagemathgh-38908: Don't (mis)use `prec_words_to_bits()` We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 8, 2024
sagemathgh-38908: Don't (mis)use `prec_words_to_bits()` We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 9, 2024
sagemathgh-38908: Don't (mis)use `prec_words_to_bits()` We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 13, 2024
sagemathgh-38908: Don't (mis)use `prec_words_to_bits()` We need to remove this function from cypari2, because pari 2.17 has changed precision from words to bits which would cause confusion. Besides, the current usage is incorrect, since `log_pari.precision()` will give the precision in *decimal digits* not in words. See: sagemath#38749 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#38908 Reported by: Gonzalo Tornaría Reviewer(s): Vincent Delecroix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove this function from cypari2, because pari 2.17 has
changed precision from words to bits which would cause confusion.
Besides, the current usage is incorrect, since
log_pari.precision()will give the precision in decimal digits not in words.
See: #38749
📝 Checklist