Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metadata from src/setup.cfg to src/pyproject.toml #38727

Closed
wants to merge 4 commits into from

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Sep 28, 2024

Cherry-picked from #38714 for easier review.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Sep 28, 2024

Documentation preview for this PR (built with commit 84de1a5; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez
Copy link
Contributor Author

The changes are an unmodified subset of #38714.
-> Author: @mkoeppe

Tests are passing (to the extend that they are normally passing), changes look good to me, thus setting to positive review.
-> Reviewer: @tobiasdiez

@tobiasdiez
Copy link
Contributor Author

Matthias, this PR was meant to help you get your code in. But sadly you do not seem to be interested in any form of compromise...

Setting this to disputed. Not sure how to count votes since Matthias is both the author as well as the disputer 🤣

@tobiasdiez tobiasdiez added s: needs review disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ and removed s: needs work labels Sep 29, 2024
@tobiasdiez tobiasdiez requested a review from dimpase September 29, 2024 08:36
@dimpase dimpase removed the disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ label Oct 21, 2024
@tobiasdiez
Copy link
Contributor Author

With the meson build now in place, I don't see a point anymore in improving the setup around setuptools. If someone still feels this is worthwhile to do, feel free to reopen.

@tobiasdiez tobiasdiez closed this Oct 28, 2024
@tobiasdiez tobiasdiez deleted the pyprojecttoml branch October 28, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants