fix some issues with make_dirty #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on test:
- make_dirty([[1,2,3]], dirty={(0,0):0, (0,1):0}) with cellzero=0
the expected result is [[3]] (but was [[2]] because it starts
removing 1 in [1,2,3], then 3 in [2,3], instead of removing
1 and 2 in [1,2,3]
- same test with non zero cell
basically, this doesn't assume the key traversal is ordered in dirty
additionaly, it use a default cellzero value (to `None`)
remove cellzero default value
zerline
force-pushed
the
develop
branch
2 times, most recently
from
7420ca5 to
7622ec1
Compare
zerline
force-pushed
the
develop
branch
4 times, most recently
from
2d5ad02 to
b9720f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically, this doesn't assume the key traversal is ordered in dirty
on test:
the expected result is [[3]] (but was [[2]] because it starts
removing 1 in [1,2,3], then 3 in [2,3], instead of removing
1 and 2 in [1,2,3]
additionaly, it use a default cellzero value (to
None)