WIP: fix #184 #181
Merged
WIP: fix #184 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankur Srivastava <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 48.49% 47.66% -0.83%
==========================================
Files 20 20
Lines 1864 1909 +45
Branches 416 428 +12
==========================================
+ Hits 904 910 +6
- Misses 671 703 +32
- Partials 289 296 +7
Continue to review full report at Codecov.
|
|
Thanks for tackling this! |
sagebind
reviewed
Apr 29, 2020
Signed-off-by: Ankur Srivastava <[email protected]>
Signed-off-by: Ankur Srivastava <[email protected]>
Signed-off-by: Ankur Srivastava <[email protected]>
Signed-off-by: Ankur Srivastava <[email protected]>
Signed-off-by: Ankur Srivastava <[email protected]>
Signed-off-by: Ankur Srivastava <[email protected]>
sagebind
reviewed
May 2, 2020
- Keep the error as enum http::Error - Commented out the failing tests until it gets fixed upstream in mockito Signed-off-by: Ankur Srivastava <[email protected]>
Thanks a lot to you as well for reviewing all the changes and the patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sagebind,
Tried to come up with something for the issue #180 .
Had to change the
default_headersignature from aselftomut self.( In case I am going in completely wrong direction, please let me know. )