Skip to content

refactor: FSD 레이어 의존성 위반 수정#26

Merged
jpark0506 merged 4 commits intodevfrom
refactor/fsd-layer-violations
Feb 22, 2026
Merged

refactor: FSD 레이어 의존성 위반 수정#26
jpark0506 merged 4 commits intodevfrom
refactor/fsd-layer-violations

Conversation

@jpark0506
Copy link
Collaborator

Summary

  • Emotion 타입을 shared/types/emotion.ts로 추출하여 shared → entities 순환 의존성 제거
  • WeeklyStatistics, MonthlyFrequencyStatistics 컴포넌트를 widgets/statistics로 이동 (entities 의존 컴포넌트가 shared에 있던 위반)
  • chat-pending 모듈을 entities/chatbot/lib으로 이동 (ChatMessage 타입 의존)
  • shared/lib/fcm 전체를 entities/fcm/lib으로 이동 (entities/fcm/api 의존)
  • 미사용 useSessionPending barrel export에서 제거

Test plan

  • TypeScript typecheck 통과
  • ESLint 통과
  • Jest 38개 테스트 통과 (chat-pending 테스트 포함)
  • 앱 빌드 및 실행 확인

🤖 Generated with Claude Code

jpark0506 and others added 2 commits February 22, 2026 01:49
- Emotion 타입을 shared/types/emotion.ts로 추출하여 shared → entities 의존성 제거
- WeeklyStatistics, MonthlyFrequencyStatistics를 widgets/statistics로 이동 (entities 의존 컴포넌트)
- chat-pending을 entities/chatbot/lib으로 이동 (ChatMessage 타입 의존)
- shared/lib/fcm을 entities/fcm/lib으로 이동 (entities/fcm/api 의존)
- useSessionPending barrel export에서 제거 (미사용 + entities 의존)

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Feb 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/fsd-layer-violations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jpark0506 jpark0506 changed the base branch from dev to refactor/apply-cursor-rules February 22, 2026 04:03
@jpark0506 jpark0506 changed the base branch from refactor/apply-cursor-rules to dev February 22, 2026 09:36
@jpark0506 jpark0506 merged commit 27308e1 into dev Feb 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant