Skip to content

Conversation

Rod0352
Copy link
Contributor

@Rod0352 Rod0352 commented Oct 3, 2025

Adds code resubmission functionality for rejected proposals/code, rejected results, and unsatisfactory results.
Changes
New Components

ResubmitButton - Navigates to resubmit page
DownloadButton - Placeholder for result downloads

Updated Components

JobResultsStatusMessage - Added resubmit/download buttons for approved and rejected results
CodeApprovalStatus - Added resubmit button for rejected code
FileApprovalStatus - Refactored to use new ResubmitButton component

Key Behaviors
Code Rejected: Shows message + "Resubmit study code" button
Results Rejected: Shows PII warning message + "Resubmit study code" button
Results Approved: Shows success message + "Download result(s)" and "Resubmit study code" buttons

@Rod0352 Rod0352 requested a review from a team October 3, 2025 08:08
Copy link

github-actions bot commented Oct 6, 2025

👎 Total coverage is lower than the default branch

Lines Branches Functions Statements
99.46% (+0.00%) 66.58% (-0.04%) 97.10% (+0.00%) 99.47% (+0.00%)

Detailed report

1 file with a coverage regression
File Lines Branches Functions Statements
🚫 src/components/study/job-approval-status.tsx 100.00% 69.23% (-1.60%) 100.00% 100.00%
src/components/study/resubmit-button.tsx 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)

Copy link
Member

@nathanstitt nathanstitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Rodney

@Rod0352 Rod0352 merged commit aaa7d3e into main Oct 13, 2025
7 checks passed
@Rod0352 Rod0352 deleted the OTTER-316-code-resubmission-correction branch October 13, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants