Skip to content

Error handling for Harbor authentication #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Error handling for Harbor authentication #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf5efd9
Updated the harbor login script.
sparksam Sep 23, 2025
69e8d11
Removed echo and comment
sparksam Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tools/harbor-login
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,19 @@ fail() {
exit 1
}
DOCKER_AUTH_FILE="$1"
HARBOR_USERNAME=$(jq -r ".username" "$DOCKER_AUTH_FILE")
HARBOR_PASSWORD=$(jq -r ".password" "$DOCKER_AUTH_FILE")
if [[ ! -r "$DOCKER_AUTH_FILE" ]]; then
echo "Cannot read file: $DOCKER_AUTH_FILE" >&2
exit 1
fi
HARBOR_USERNAME=$(jq -r ".name" "$DOCKER_AUTH_FILE")
HARBOR_PASSWORD=$(jq -r ".secret" "$DOCKER_AUTH_FILE")
SERVER_ENDPOINT=$(jq -r ".serveraddress" "$DOCKER_AUTH_FILE")
for var in HARBOR_USERNAME HARBOR_PASSWORD SERVER_ENDPOINT; do
if [[ -z "${!var:-}" || "${!var}" == "null" ]]; then
echo "Error: $var is missing or empty" >&2
exit 1
fi
done
NAMESPACE="${NAMESPACE:-default}"
K8S_SECRET="${K8S_SECRET:-si-docker-config}"
SETUP_APP_SA="${SETUP_APP_SA:-setup-app-sa}"
Expand Down