Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relay-kit): Add Entrypoint v0.7 support #1103

Open
wants to merge 41 commits into
base: development
Choose a base branch
from

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Jan 17, 2025

What it solves

Resolves #845 #1101

How this PR fixes it

We are adding support for entrypoint v0.7

Now you can choose safeModulesVersion 0.3.0 when calling the init() method of the Safe4337Pack. This module version is the one compatible with entrypoint v0.7

Upgrade path

For existing Safes that want to upgrade to use the v0.7 version:

  1. Should enable the 0.3.0 module
  2. Should update the fallback handler to be the new enabled module

Could be through the protocol-kit or through the transaction service

@yagopv yagopv linked an issue Jan 17, 2025 that may be closed by this pull request
@yagopv yagopv changed the title feat(realay-kit): Add Entrypoint v0.7 support feat(relay-kit): Add Entrypoint v0.7 support Jan 20, 2025
@yagopv yagopv requested review from DaniSomoza and dasanra January 28, 2025 14:18
@yagopv yagopv marked this pull request as ready for review January 28, 2025 14:18
…e-sdk into feat/entrypoint-v7

# Conflicts:
#	packages/api-kit/src/SafeApiKit.ts
#	packages/relay-kit/src/packs/safe-4337/Safe4337Pack.test.ts
#	packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts
#	packages/relay-kit/src/packs/safe-4337/SafeOperation.ts
#	packages/relay-kit/src/packs/safe-4337/utils.ts
@coveralls
Copy link

coveralls commented Jan 30, 2025

Pull Request Test Coverage Report for Build 13077066984

Details

  • 163 of 189 (86.24%) changed or added relevant lines in 15 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.0%) to 72.784%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api-kit/src/utils/safeOperation.ts 0 1 0.0%
packages/relay-kit/src/packs/safe-4337/SafeOperationFactory.ts 6 7 85.71%
packages/relay-kit/src/packs/safe-4337/estimators/pimlico/PimlicoFeeEstimator.ts 30 32 93.75%
packages/relay-kit/src/packs/safe-4337/utils/index.ts 12 14 85.71%
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts 25 28 89.29%
packages/relay-kit/src/packs/safe-4337/utils/userOperations.ts 25 28 89.29%
packages/relay-kit/src/packs/safe-4337/SafeOperationV07.ts 4 18 22.22%
Files with Coverage Reduction New Missed Lines %
packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts 4 84.48%
Totals Coverage Status
Change from base Build 13073997378: -2.0%
Covered Lines: 850
Relevant Lines: 1054

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants