feat: add ContractGraph QA evidence interoperability - #132
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
safal207
left a comment
There was a problem hiding this comment.
Codex exact-head re-review — no blocking findings at 60d588ec983210f34a3cf385cb6205782a8e44f6.
Initial CI findings were fixed: canonical rustfmt output applied and the disallowed Option::unwrap removed. The file-only commands return before LIMINAL-DB opens; imported CGQA data remains bounded evidence and exported candidates remain non-authoritative seeds requiring independent CGQA verification. CI, stable/beta tests, build, rustfmt, Clippy and Security Audit are green. Draft remains unmerged.
safal207
left a comment
There was a problem hiding this comment.
Codex exact-head review — no blocking findings at 0336fd7b6b6a4c65019dc23da94123ba5dc16226 (tree bebb6317258420cf43cae5885829cdfe17dfc55e).
Reviewed the native Rust conformance runner, strict candidate validation, mutation/hash-before-adapter path, CLI wiring, vendored canonical assets, tests, and authority boundary. The first CI cycle's rustfmt and disallowed-unwrap findings were corrected; the exact reviewed head now passes stable/beta tests, build, formatting, Clippy, Trivy, and cargo-audit. The independent Python reference runner also reports 14/14 on the same suite bytes.
The runner remains offline and non-authorizing: no LIMINAL-DB open, network request, candidate execution, or target-system side effect. Verdict is bounded to suite SHA-256 562e2f9ae699f001b9ccf1b2b9f6dd30c435d53d668b5fd9a04ca15ca1e4faac; it does not establish production safety, completeness, or permission to act. Draft remains unmerged.
safal207
left a comment
There was a problem hiding this comment.
Codex exact-head review — PASS
Reviewed exact head a4eea38f1cecac2f4a2e55860dc5ea9a52697a1e (tree 018401888e7d1a66700e07b46ada2f99b07ce85f).
No blocking findings.
- The new delta is documentation-only and points users to the single canonical multilingual/SDK hub instead of duplicating protocol semantics.
- Existing Rust adapter and 14-vector conformance behavior are unchanged.
- Authority remains bounded: candidates are non-authoritative, require fresh CGQA verification, and cannot compute an LTP verdict or authorize an action.
- GitHub CI and Security Audit both passed on this exact head.
- Unresolved review threads: 0.
Synthetic conformance remains limited to the pinned fixtures and mutations. This review does not request or perform a merge.
safal207
left a comment
There was a problem hiding this comment.
Codex exact-head review — PASS_WITHIN_BOUND
Reviewed exact head 1f27cd10eb872a316d6bd2536913ed92290a20c5 (tree e19ce2aeb017d65701172073de0b8f29ab5c8a8d).
No blocking findings.
- The final delta is documentation-only and replaces branch-relative cross-repository links with immutable ContractGraph-QA commit
3ff86db99ecb0eeae7fa4b517ac7c8a157a2441a. - All five localized quickstarts and the shared SDK matrix resolve at that exact commit.
- The native Rust adapter and 14-vector conformance behavior are unchanged.
- Candidates remain non-authoritative, require fresh CGQA verification, and cannot compute an LTP verdict or authorize an action.
- GitHub CI and Security Audit both passed on this exact head.
- Unresolved review threads before submission: 0.
Synthetic conformance remains bounded to the pinned fixtures and mutations. This is not production validation, a completeness/security proof, registry publication, or permission to act. The PR remains draft and unmerged.
Scope
Canonical conformance suite
cgqa-liminalqa-v0.1562e2f9ae699f001b9ccf1b2b9f6dd30c435d53d668b5fd9a04ca15ca1e4faaccargo run --bin limctl -- cgqa-conformanceAuthority boundary
Candidates remain hypotheses with
mayAuthorizeAction=falseandrequiresCgqaVerification=true. The conformance runner performs no network, database, candidate execution, or target-system action. LTP remains the continuity-verdict owner. Shared SDKs validate report evidence only.Validation at exact head
Exact head:
1f27cd10eb872a316d6bd2536913ed92290a20c5Exact tree:
e19ce2aeb017d65701172073de0b8f29ab5c8a8d3ff86db99ecb0eeae7fa4b517ac7c8a157a2441aSynthetic conformance only establishes behavior for the pinned fixtures and mutations. It is not production validation, a completeness/security proof, or action authorization.
Draft for review. No merge requested.