Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Extends the bounded public Tradernet quote-stream audit from server-message integrity to deterministic client-state consequences.
Parent PR #120 reproduced monotonic
n/revwith repeated approximately 15-minute backwardlttjumps. This stacked PR tests the next causal transition:The same exact trace is replayed through a guarded reducer that suppresses
ltt,ltp, andltswhen market time materially regresses without explicit provenance.Exact result
Exact audited head:
879262b3e14785fdffd6be47867f4cb43a7f7f24.Workflow run
30280948711completed successfully with exact-head identity, clean initial/final worktrees, immutable manifest, evidence artifact and receipt.TRD-RED-001 — confirmed reducer-level defect candidate
The naive reducer accepted 15 materially backward-time messages because every message had non-decreasing
n/rev.AAPL.US,MSFT.US;15;15.Verdict:
CONFIRMED_DEFECT_CANDIDATEfor the conventional reducer model.TRD-RED-002 — price/size state also changes
All 15 backward-time payloads also changed
ltpand/orlts.Example:
This proves that the observed trace can deterministically roll back more than a timestamp label under shallow merge. It does not prove that the production Tradernet UI uses this reducer.
TRD-RED-003 — repeated snapshot is not stale
The repeated identical subscription produced two new
init=1snapshots, one per ticker.2;0;ltpmatched the current state.Verdict:
REINITIALIZATION_SIGNAL, not a defect candidate in this run.TRD-RED-004 — no explicit provenance
All 15 contradictory updates lacked an explicit feed/source/delay/entitlement provenance field.
Verdict:
SYSTEM_CONTRACT_SIGNAL. The audit does not identify the upstream producer.Causal conclusion
A conventional reducer that trusts monotonic
n/revand shallow-merges partial quote payloads is sufficient to reproduce visible market-time and price/size rollback from the bounded public demo trace. A provenance-aware freshness guard prevented all 15 deterministic rollback effects.Evidence
30280948711;8658790542;sha256:79dfc687b5c72a0185f128d0f544764ca6ce3089c54bd9fe38c12dd4d6d3ddc7;8658790877;sha256:f0e9feaad0f2dd7295a6f1cc5941241a9e3727270d3feaf4e34c0c9bcd25f030.Safety boundary
Public unauthenticated demo stream only, two tickers, one active socket, one controlled reconnect and one repeated identical subscription.
No market depth, account, portfolio, order entry, financial operation, malformed protocol message, fuzzing, concurrency, load testing, active security testing, external contact, deployment or merge.
Claim boundary
The result proves a deterministic client-state consequence for a conventional reducer model. It does not prove the exact production Tradernet reducer, upstream venue, entitlement source, production-account behavior or order-execution impact. Exact production implementation remains
NEEDS_AUTHORISED_EVIDENCE.This PR remains draft and stacked on PR #120.