Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
refs/pull/<n>/mergerevision;run_id-run_attemptname;manifest.jsonwith repository, workflow SHA, expected/initial/final SHA, run ID, run attempt, timestamps, file sizes, and SHA-256 digests;artifact-receipt.jsonbinding the manifest to GitHub's artifact ID, URL, and artifact digest;Root cause
The previous workflows relied on the default pull-request checkout behavior. GitHub Actions therefore checked out a synthetic merge revision while the audit report described the PR head SHA. Re-runs also reused the same run ID and artifact name, leaving the evidence identity ambiguous without
run_attempt, artifact ID, and digest.The first fail-closed execution also exposed an untracked Python
__pycache__generated by the helper validation step. The helper check now parses the source without writing bytecode and runs tests withPYTHONDONTWRITEBYTECODE=1; the final clean-worktree gate remains strict.Safety boundary
This remains an advisory, read-only public observation. The change does not add authentication, form submission, portfolio access, orders, financial operations, fuzzing, load testing, deployment, or repository write credentials.
Exact-head validation
Current PR head:
3a6ca6430691f45c3a0d0c5473aab96d439b23ec.All exact-head checks completed successfully:
30224538046;30224538037;30224538050;30224538039.Both Tradernet workflows passed:
Artifact verification
Mobile image evidence
8638182559;dc95d6b3b530167cc031c57abefc2ae5b60b0f4330e6fa739e77fd2dc5e42285;541329ce6b7f72af62d6d6bc5c8ee3b0f28940380b57e91ef372702f0ac3a34d;8638182660.Public terminal loading evidence
8638192000;a907bd558d990d412f531b403ddc99fcc4386378df5fbaaf55cb2f41077b820d;ec8ee00c25832b0d399a9e01d2d14fb570c1bd4c9e3350982bc37e46312a142d;8638192166.Downloaded ZIP SHA-256 values match GitHub's artifact digests. Each receipt matches its manifest digest, run ID, run attempt, artifact ID, and artifact digest. Every file listed in both manifests matches its recorded size and SHA-256.
Local validation
run_id,run_attempt, manifest digest, artifact ID, and artifact digest;Follow-up not included
Canonical LTP JSONL generation and deterministic offline replay remain a separate follow-up. This PR fixes evidence identity first and does not claim that live browser recapture is deterministic replay.