Skip to content

test: prepare upstream fixes for Claude Code Action #1522 and tee-output #3 - #107

Open
safal207 wants to merge 9 commits into
mainfrom
agent/upstream-contributor-kits-v0-1
Open

safal207 wants to merge 9 commits into
mainfrom
agent/upstream-contributor-kits-v0-1

Conversation

@safal207

@safal207 safal207 commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

Prepares two small, fork-ready upstream contributions without modifying either upstream repository.

Boris Cherny / anthropics/claude-code-action#1522

Pinned source:

b76a0776ae74036e77cd11018083743453d7ad35

The triggering pull_request_review currently shares its submitted_at with triggerTime, so the strict timestamp filter removes the very review that launched the workflow, including its inline comments.

Candidate contract:

retain only the exact triggering review by webhook database ID
reject unrelated reviews at the same timestamp
reject edits strictly after the trigger
retain inline comments
avoid duplicating the review body already supplied by the webhook

Validation:

focused Bun regression tests
TypeScript typecheck
Prettier format gate
git diff --check

Greg Brockman / gdb/tee-output#3

Pinned source:

c41f8ff383200320b746e953e92709ae1b505a71

The investigation showed two distinct lifecycle boundaries:

process spawned != reader ready
reader ready != output drained

The final candidate replaces external tee with a small bundled binary relay and uses two ordered acknowledgements:

open output targets
→ READY
→ normal writes
→ flush Python buffers
→ random sentinel appended to the same PTY/pipe stream
→ relay persists every preceding byte and removes the sentinel
→ DRAIN_ACK over a separate status pipe
→ restore descriptors and close writer
→ natural process completion
→ SIGINT only as bounded fallback

Validation:

Linux + macOS
Python 3.11 + 3.13
PTY print → traceback → immediate close
25 rounds per coordinate
100/100 trajectories on the validated head

Boundary

These are candidate patches and regression tests, not claims that either upstream project has accepted the diagnosis or fix. External publication still requires user-owned GitHub forks. No upstream issue, branch, label, review, approval, or merge state is modified here.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@safal207, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 954adc48-c6c6-4ff3-9cf8-02f1ee6af690

📥 Commits

Reviewing files that changed from the base of the PR and between d1caf64 and 68c8a49.

📒 Files selected for processing (4)
  • .github/workflows/upstream-contributor-kits.yml
  • contrib/upstream-contributor-kits/README.md
  • contrib/upstream-contributor-kits/apply_boris_1522.py
  • contrib/upstream-contributor-kits/apply_greg_3.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/upstream-contributor-kits-v0-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Final exact-head contributor receipt

Both upstream candidate patches are validated on the current PR head.

head: 68c8a49a46505521d8c31ae2ff73a4515e6c0942
run: 29784617271
status: PASS

Boris / anthropics/claude-code-action#1522

upstream: b76a0776ae74036e77cd11018083743453d7ad35
artifact: 8477959870
artifact digest:
sha256:1a9825ba6fa3855e6761e98617ce8495463c31cfef676608fb565af3aa4a448f
patch digest:
sha256:b2701ed05b3ae0e119fa93c177faf9fc7f685800300b4335dbc2fc67bfc45c26

Validated: focused regression tests, TypeScript typecheck, formatting, and patch integrity.

Greg / gdb/tee-output#3

upstream: c41f8ff383200320b746e953e92709ae1b505a71
representative artifact: 8477960279
artifact digest:
sha256:dff56b4f26dde9899e84694e6720ecedd46efff240dae176c991d5f51bb41e18
patch digest:
sha256:df577ad15fe93ab379faf06476e25316894f51f1a80997cdd0cd5084e4d162d7

Validated matrix:

Linux Python 3.11: 25/25
Linux Python 3.13: 25/25
macOS Python 3.11: 25/25
macOS Python 3.13: 25/25
Total:              100/100

Protocol under test:

READY
→ user writes
→ in-stream random sentinel
→ persist every preceding byte
→ DRAIN_ACK
→ descriptor restoration and close
→ natural exit, SIGINT only as fallback

Boundary: these are contributor-ready candidate patches. No upstream fork, branch, issue state, approval, or merge was modified by this PR.

@safal207
safal207 marked this pull request as ready for review July 20, 2026 23:17
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant