Skip to content

test: define Claude Code collapsed primary-identifier contract - #104

Draft
safal207 wants to merge 8 commits into
agent/greg-boris-open-work-review-2026-07-20from
agent/boris-primary-identifier-contract-v0-1
Draft

safal207 wants to merge 8 commits into
agent/greg-boris-open-work-review-2026-07-20from
agent/boris-primary-identifier-contract-v0-1

Conversation

@safal207

Copy link
Copy Markdown
Owner

Summary

Adds a bounded public-evidence and product-contract investigation for anthropics/claude-code#21151, assigned to bcherny.

This is stacked on the original Greg/Boris public review in PR #96.

Question

Should collapsed file-operation events preserve a visible primary identifier without requiring ctrl+o expansion?

Evidence model

public issue + comments + tracker head
  -> reference renderer matrix
  -> LPI identity transition
  -> CaPU opaque-security-event gate
  -> T-Trace
  -> TTM replay
  -> SDP hypothesis collapse
  -> DRP decision history
  -> notification authority gate

Bounded matrix

5 tools: Read / Write / Edit / Glob / Grep
x 2 cardinalities
x 4 outcomes
x 2 target variants
= 80 core scenarios
+ 4 privacy/disambiguation edge cases

Exact component refs

LPI     0683ca3731256d5fc06f60c14a3deb9e9c149d19
CaPU    babd2945046d2564e1110a76741827560c57fcca
T-Trace 6a0755dbe8a89decd325298ec4563b9bb16adc62
TTM DB  eeded6bf5666512a23a7477eb8cda6485dfd173a
SDP     f1903aecb1f9196414c49784558f6ed9f40d8bda
DRP     92e63d7d4eeb55f8eb61956da002dc8951bab1c6

Boundary

The public repository does not expose the complete Claude Code TUI implementation, and this workflow does not execute an installed Claude Code runtime.

The reference renderer is disclosed test code. A green result may support a product contract and current-product acceptance criteria. It may not claim source-level implementation findings, a current fix, or authority to close/change the upstream issue.

Read-only. No upstream comments, labels, assignments, closes, approvals, or merges are performed by this PR.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 926a5874-aaba-480d-ab23-ad5079faaa13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/boris-primary-identifier-contract-v0-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Exact-head primary-identifier contract result

The bounded public-evidence and product-contract workflow completed successfully on:

head: 3eaeb5a72fa5ea24f0b1080811d44f3eca90aa1f
run: 29781791285
artifact: 8476918777
artifact digest: sha256:760b99a9b470e74fbb6be526186b27f38550fc9e6a676f9fbfc2e8253ee1bb47
tracker main SHA: 015170d3fd84fb57ef4685a64b673fadd0690dc1

Final machine verdict:

READY_TO_NOTIFY_PRIMARY_IDENTIFIER_CONTRACT_SUPPORTED_IMPLEMENTATION_NOT_VERIFIED

Live public evidence

issue: anthropics/claude-code#21151
state: open
assignee: bcherny
public comments fetched: 132
unique public authors: 52

Selected public signals:

expert observability preference: 12
Ctrl+O not sufficient:           9
configuration requested:         9
search pattern hidden:           7
auditability needed:             3
blocked identifier needed:       2
steering failure risk:           2
2.1.19 -> 2.1.20 regression:     2

Comment bodies are not copied into the final packet. The evidence layer retains hashes plus bounded signal records.

Bounded reference matrix

5 tools x 2 cardinalities x 4 outcomes x 2 variants
= 80 core scenarios
+ 4 privacy/disambiguation edge cases
= 84 total scenarios
Measure Reported abstraction model Reference contract
Visible primary identifiers 0/84 84/84
Critical blocked/denied identifier coverage 42/42
Unique collapsed outputs 33 84
Collision groups 32 0
Scenarios in collision groups 83 0

The reference renderer keeps output bounded to 120 characters, renders workspace-relative paths, exposes Grep/Glob patterns rather than contents, samples multiple identifiers with a remaining-count suffix, preserves duplicate-basename context, and permits middle truncation only when stable prefix and suffix anchors remain visible.

Causal stack

T-Trace records: 252
TTM records: 420
TTM replay errors: 0
TTM chain head: a58473a72b817655ee73827dbba3f2f58ff1d7dbaf81ed55f693e91d20101020
SDP selected: H2_PRIMARY_IDENTIFIER_MISSING
blocking checks: 0

SDP comparison:

H1_VERBOSE_EXPANSION_IS_SUFFICIENT  0.10  not selected
H2_PRIMARY_IDENTIFIER_MISSING       1.00  supported
H3_CONFIGURATION_ONLY               0.55  candidate
H4_FULL_DETAILS_ALWAYS_VISIBLE      0.25  not selected

Claim boundary

This packet supports a product contract and a disclosed reference renderer. It does not claim:

  • access to Claude Code's private TUI source;
  • verification of the current installed Claude Code runtime;
  • that the current release is broken or fixed;
  • that the reference wording must be adopted exactly;
  • authority to close or change the upstream issue.

Recommended lifecycle verdict:

KEEP_OPEN_PENDING_CURRENT_PRODUCT_VERIFICATION

No upstream comment, state, label, assignment, approval, close, or merge was changed.

Copy link
Copy Markdown
Owner Author

Delivery record

The exact-head primary-identifier evidence was prepared for anthropics/claude-code#21151.

Direct upstream delivery was attempted and blocked by the GitHub integration:

403 Resource not accessible by integration

Fallback public notification was posted with @bcherny in the existing Boris evidence thread:

#99 (comment)

Delivered evidence:

run: 29781791285
head: 3eaeb5a72fa5ea24f0b1080811d44f3eca90aa1f
artifact: 8476918777
artifact digest:
sha256:760b99a9b470e74fbb6be526186b27f38550fc9e6a676f9fbfc2e8253ee1bb47
verdict: READY_TO_NOTIFY_PRIMARY_IDENTIFIER_CONTRACT_SUPPORTED_IMPLEMENTATION_NOT_VERIFIED

Boundary preserved: notification only. No upstream labels, assignments, closure, approval, code, or merge state was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant