feat: 푸시 알림 기능 #93
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| /build | ||
| .idea/ | ||
| /release | ||
| /google-services.json |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,28 @@ | ||
| package com.saegil.android | ||
|
|
||
| import android.app.Application | ||
| import com.google.firebase.Firebase | ||
| import com.google.firebase.messaging.messaging | ||
| import com.kakao.sdk.common.KakaoSdk | ||
| import dagger.hilt.android.HiltAndroidApp | ||
| import timber.log.Timber | ||
| import androidx.core.content.edit | ||
|
|
||
| @HiltAndroidApp | ||
| class App : Application() { | ||
| override fun onCreate() { | ||
| super.onCreate() | ||
| KakaoSdk.init(this, BuildConfig.NATIVE_APP_KEY) | ||
| Timber.plant(Timber.DebugTree()) | ||
| Firebase.messaging.token.addOnCompleteListener { task -> | ||
| if (task.isSuccessful) { | ||
| val deviceToken = task.result | ||
|
|
||
| getSharedPreferences("fcm", MODE_PRIVATE) | ||
| .edit { | ||
| putString("deviceToken", deviceToken) | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+17
to
+26
There was a problem hiding this comment. The task completion listener currently only handles the success case. If Firebase.messaging.token.addOnCompleteListener { task ->
if (task.isSuccessful) {
val deviceToken = task.result
getSharedPreferences("fcm", MODE_PRIVATE)
.edit {
putString("deviceToken", deviceToken)
}
} else {
Timber.w(task.exception, "Fetching FCM registration token failed")
}
} |
||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,54 @@ | ||||||||||
| package com.saegil.android | ||||||||||
|
|
||||||||||
| import android.app.NotificationChannel | ||||||||||
| import android.app.NotificationManager | ||||||||||
| import android.os.Build | ||||||||||
| import androidx.core.app.NotificationCompat | ||||||||||
| import com.google.firebase.messaging.FirebaseMessagingService | ||||||||||
| import com.google.firebase.messaging.RemoteMessage | ||||||||||
| import dagger.hilt.android.AndroidEntryPoint | ||||||||||
| import androidx.core.content.edit | ||||||||||
|
|
||||||||||
| @AndroidEntryPoint // Hilt 쓰는 경우 | ||||||||||
|
There was a problem hiding this comment. Comment contains Korean text. Use English for code comments to maintain consistency and accessibility for international developers.
Suggested change
|
||||||||||
| class SaegilFirebaseMessagingService : FirebaseMessagingService() { | ||||||||||
|
|
||||||||||
| override fun onNewToken(token: String) { | ||||||||||
| super.onNewToken(token) | ||||||||||
|
|
||||||||||
| getSharedPreferences("fcm", MODE_PRIVATE) | ||||||||||
| .edit { | ||||||||||
| putString("deviceToken", token) | ||||||||||
| } | ||||||||||
| } | ||||||||||
|
|
||||||||||
| override fun onMessageReceived(remoteMessage: RemoteMessage) { | ||||||||||
| super.onMessageReceived(remoteMessage) | ||||||||||
|
|
||||||||||
| val title = remoteMessage.notification?.title ?: "알림" | ||||||||||
|
There was a problem hiding this comment. Default notification title is hardcoded in Korean. Consider using string resources for localization and consistency. |
||||||||||
| val body = remoteMessage.notification?.body ?: "내용 없음" | ||||||||||
|
There was a problem hiding this comment. Default notification body is hardcoded in Korean. Consider using string resources for localization and consistency.
Comment on lines
+27
to
+28
There was a problem hiding this comment. The default values for the notification title and body are hardcoded. Use string resources (
Suggested change
|
||||||||||
| showNotification(title, body) | ||||||||||
| } | ||||||||||
|
|
||||||||||
| private fun showNotification(title: String, message: String) { | ||||||||||
| val channelId = "default_channel" | ||||||||||
|
There was a problem hiding this comment. The notification channel ID is hardcoded. Define this as a constant in a companion object or a separate constants file to avoid typos and improve maintainability. |
||||||||||
|
|
||||||||||
| val notificationManager = | ||||||||||
| getSystemService(NOTIFICATION_SERVICE) as NotificationManager | ||||||||||
|
|
||||||||||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||||||||||
| val channel = NotificationChannel( | ||||||||||
| channelId, | ||||||||||
| "기본 알림 채널", | ||||||||||
|
There was a problem hiding this comment. Notification channel name is hardcoded in Korean. Consider using string resources for localization and consistency. There was a problem hiding this comment. The channel name is hardcoded. This user-visible string should be a string resource (
Suggested change
|
||||||||||
| NotificationManager.IMPORTANCE_DEFAULT | ||||||||||
| ) | ||||||||||
| notificationManager.createNotificationChannel(channel) | ||||||||||
| } | ||||||||||
| val notification = NotificationCompat.Builder(this, channelId) | ||||||||||
| .setSmallIcon(R.drawable.ic_saegil_logo) | ||||||||||
| .setContentTitle(title) | ||||||||||
| .setContentText(message) | ||||||||||
| .setAutoCancel(true) | ||||||||||
| .build() | ||||||||||
|
Comment on lines
+46
to
+51
There was a problem hiding this comment. The created notification does not have a |
||||||||||
| notificationManager.notify(System.currentTimeMillis().toInt(), notification) | ||||||||||
|
There was a problem hiding this comment. Using
Suggested change
|
||||||||||
| } | ||||||||||
| } | ||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| /build | ||
| /google-services.json |
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,17 +1,27 @@ | ||||||||||||||
| package com.saegil.data.remote | ||||||||||||||
|
|
||||||||||||||
| import android.util.Log | ||||||||||||||
| import com.saegil.data.model.NewsItemDto | ||||||||||||||
| import com.saegil.data.remote.HttpRoutes.NEWS | ||||||||||||||
| import com.saegil.data.remote.HttpRoutes.TEST | ||||||||||||||
| import io.ktor.client.HttpClient | ||||||||||||||
| import io.ktor.client.call.body | ||||||||||||||
| import io.ktor.client.request.get | ||||||||||||||
| import io.ktor.client.request.parameter | ||||||||||||||
| import io.ktor.client.request.post | ||||||||||||||
| import javax.inject.Inject | ||||||||||||||
|
|
||||||||||||||
| class NewsServiceImpl @Inject constructor( | ||||||||||||||
| private val client: HttpClient | ||||||||||||||
| ): NewsService { | ||||||||||||||
|
|
||||||||||||||
| override suspend fun getNewsByTopics(): List<NewsItemDto> { | ||||||||||||||
| val testResponse = client.post(TEST) { | ||||||||||||||
| parameter("title", "테스트 알림") | ||||||||||||||
| parameter("body", "내용입니다.") | ||||||||||||||
| } | ||||||||||||||
| Log.d("경로",testResponse.toString()) | ||||||||||||||
|
There was a problem hiding this comment. Debug logging with Korean text should be removed from production code. Use proper logging framework like Timber if logging is needed. |
||||||||||||||
| Log.d("경로",testResponse.body()) | ||||||||||||||
|
Comment on lines
+19
to
+24
There was a problem hiding this comment. Test notification code is mixed with production news retrieval logic. This should be removed or moved to a separate testing mechanism to keep production code clean.
Suggested change
There was a problem hiding this comment. Debug logging with Korean text should be removed from production code. Use proper logging framework like Timber if logging is needed.
Comment on lines
+19
to
+24
There was a problem hiding this comment. This block of code appears to be for testing the push notification functionality. This test code, including the API call and logging, should not be part of the production codebase. Remove it. Use return client.get(NEWS).body() |
||||||||||||||
| return client.get(NEWS).body() | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug application ID suffix is commented out. This should be properly configured or removed if no longer needed, as it affects app installation and Firebase configuration.