Skip to content

fix(request): properly compute absolute url#257

Merged
phil-davis merged 1 commit into
sabre-io:masterfrom
skjnldsv:patch-1
Sep 9, 2025
Merged

fix(request): properly compute absolute url#257
phil-davis merged 1 commit into
sabre-io:masterfrom
skjnldsv:patch-1

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Fix #256

@staabm

staabm commented Aug 6, 2025

Copy link
Copy Markdown
Member

needs a unit test

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv

skjnldsv commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

needs a unit test

Coming in hot! 🚀

@skjnldsv

Copy link
Copy Markdown
Contributor Author

@staabm any news?

@staabm staabm requested a review from phil-davis August 20, 2025 18:28
@codecov

codecov Bot commented Aug 20, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.24%. Comparing base (52a40de) to head (66bc794).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #257      +/-   ##
============================================
+ Coverage     94.21%   94.24%   +0.02%     
- Complexity      261      262       +1     
============================================
  Files            15       15              
  Lines           882      886       +4     
============================================
+ Hits            831      835       +4     
  Misses           51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@staabm staabm requested a review from DeepDiver1975 August 23, 2025 07:50

@staabm staabm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phil-davis phil-davis merged commit db4969b into sabre-io:master Sep 9, 2025
8 checks passed
@phil-davis

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getAbsoluteUrl computation logic error

3 participants