Skip to content

Check node type before getOwner() call#1614

Open
alecpl wants to merge 1 commit into
sabre-io:masterfrom
alecpl:dev/fix-1345
Open

Check node type before getOwner() call#1614
alecpl wants to merge 1 commit into
sabre-io:masterfrom
alecpl:dev/fix-1345

Conversation

@alecpl

@alecpl alecpl commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Fixes #1345

@codecov

codecov Bot commented Dec 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.21%. Comparing base (ed901a9) to head (6313e8d).
⚠️ Report is 46 commits behind head on master.

Files with missing lines Patch % Lines
lib/CalDAV/Schedule/Plugin.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1614      +/-   ##
============================================
- Coverage     97.23%   97.21%   -0.03%     
- Complexity     2836     2838       +2     
============================================
  Files           175      175              
  Lines          9028     8854     -174     
============================================
- Hits           8778     8607     -171     
+ Misses          250      247       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@ChristophWurst

Copy link
Copy Markdown
Contributor

Coverage dropped a bit. A test case in tests/Sabre/CalDAV/Schedule/PluginBasicTest.php should help.

@alecpl

alecpl commented Dec 30, 2025

Copy link
Copy Markdown
Contributor Author

I'm not sure how to reproduce or add a test for this case. So, someone else would have to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

\Sabre\CalDAV\Schedule\Plugin::beforeUnbind calls \Sabre\DAVACL\IACL::getOwner without a type check

2 participants