Skip to content

Add test for #1000#1608

Open
alecpl wants to merge 3 commits into
sabre-io:masterfrom
alecpl:dev/fix-1000
Open

Add test for #1000#1608
alecpl wants to merge 3 commits into
sabre-io:masterfrom
alecpl:dev/fix-1000

Conversation

@alecpl

@alecpl alecpl commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Seems the issue is already fixed.

@codecov

codecov Bot commented Dec 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (ed901a9) to head (46c46d4).
⚠️ Report is 48 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1608      +/-   ##
============================================
+ Coverage     97.23%   97.24%   +0.01%     
  Complexity     2836     2836              
============================================
  Files           175      175              
  Lines          9028     8852     -176     
============================================
- Hits           8778     8608     -170     
+ Misses          250      244       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@staabm

staabm commented Dec 5, 2025

Copy link
Copy Markdown
Member

thank you.

could you double check whether this test fails with a sabre/dav version from sept 2017?

@alecpl

alecpl commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

Not really, seems SabreDAV 3.2 requires PHP <7.2.

@evert

evert commented Dec 11, 2025

Copy link
Copy Markdown
Member

I think this bug may appear only with the CalDAV PDO backend. This test uses CalDAV\Backend\Mock deep under the hood

@alecpl

alecpl commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

I think this bug may appear only with the CalDAV PDO backend. This test uses CalDAV\Backend\Mock deep under the hood

I added a PDO backend test. Still green.

self::assertTrue(in_array('event2', $result));
}

public function testCalendarQueryGH1000()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function testCalendarQueryGH1000()
public function testCalendarQueryGH1000(): void

Comment on lines +18 to +29
protected $setupCalDAV = true;

protected $caldavCalendars = [
[
'id' => 1,
'name' => 'Calendar',
'principaluri' => 'principals/user1',
'uri' => 'calendar1',
],
];

protected $caldavCalendarObjects = [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected $setupCalDAV = true;
protected $caldavCalendars = [
[
'id' => 1,
'name' => 'Calendar',
'principaluri' => 'principals/user1',
'uri' => 'calendar1',
],
];
protected $caldavCalendarObjects = [
protected bool $setupCalDAV = true;
protected array $caldavCalendars = [
[
'id' => 1,
'name' => 'Calendar',
'principaluri' => 'principals/user1',
'uri' => 'calendar1',
],
];
protected array $caldavCalendarObjects = [

],
];

public function testIssue211()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function testIssue211()
public function testIssue211(): void

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants