feat: add systemd provider#611
Draft
Tarow wants to merge 3 commits intosablierapp:mainfrom
Draft
Conversation
|
Member
|
Hey @Tarow ! Thanks for this nice contribution! Do you think we could add tests using testcontainers ? That should work inside a clean ubuntu image right ? We could write some helper functions to manipulate the systemd files. I will take a closer look to the files when I have time, I'm quite busy at the moment. |
Author
|
Getting systemd to work in Docker containers can be a bit tricky. AFAIK it only works in rootful containers and i'm not sure if/how good it will work with Testcontainers. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #148
As of now it's still WIP as tests will have to be added etc.