feat(config): add readyOnStart option to dynamic strategy#52
Open
ngoc-minh-do wants to merge 1 commit into
Open
feat(config): add readyOnStart option to dynamic strategy#52ngoc-minh-do wants to merge 1 commit into
ngoc-minh-do wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
ready_on_startquery parameter to the dynamic strategy. Whentrue, Sablier returnsX-Sablier-Session-Status: readyimmediately regardless of instance health — the reverse proxy passes the request through without showing a waiting page.The per-instance
sablier.ready-on-startlabel controls behavior per container. The query param does the same, but at the middleware level — no labels needed.Why
Sometimes you want different behavior depending on which service is accessed:
Home Assistant + Frigate: When loading the HA dashboard, you want Frigate to start in the background — no need to wait. But when accessing Frigate's own UI directly, you want the waiting screen to confirm it's ready.
Chat app + LiteLLM proxy: When users open the chat, LiteLLM starts alongside without blocking. Direct access to LiteLLM UI get the waiting screen.
Usage
GET /api/strategies/dynamic?group=myapp&ready_on_start=true
Plugin-side config (separate PRs):