added styling for video element and fixed issue with safari image capture #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture (ios does not have ImageCapture element)
sabitertan
reviewed
Feb 18, 2024
|
|
||
| this.lastPicture = canvas.toDataURL(type); | ||
| }); | ||
| canvas.width = video.videoWidth; |
Owner
There was a problem hiding this comment.
Style changes are good, but this is another concern we need to address in another PR, also keep ImageCapture and if video parameter passed use it otherwise rely on ImageCapture path.
sabitertan
reviewed
Feb 18, 2024
| } | ||
|
|
||
| public async Task<string> Capture(ElementReference canvas) | ||
| public async Task<string> Capture(ElementReference canvas, ElementReference video) |
Owner
There was a problem hiding this comment.
Please split this into another PR, too many changes here, this may need a major version change.
Author
|
alright, that seams reasonable and would it be enough if i did this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
I've added image styling for the video element, which would let you for example set width 100% or maybe have border radius for the video element , very useful when you have full width video element
i've also fixed an issue with Ios safari, it doesn't have ImageCapture object by default, I've passed the video element to the capture method and extracted the image from there ,
I've tested this method on another project with the exact same code and it works perfectly