Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .drawer-end nesting #3254

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

willtcarey
Copy link
Contributor

Fixes #3249

This is not a bug that happens when you only have a single drawer on the page. But when you have 2 drawers nested, and the outer drawer was a drawer-end variant, then both drawer toggles would open the end drawer.

Here's a comparison of what happened before and after

Before
https://github.com/user-attachments/assets/8d228aa0-568c-4e4b-a551-4fd450eded9f

After
https://github.com/user-attachments/assets/b7f274cd-0802-48b0-ac00-9ef6aacee528

@saadeghi saadeghi merged commit 1c39933 into saadeghi:master Oct 28, 2024
1 check failed
@saadeghi
Copy link
Owner

Thank you!

@willtcarey willtcarey deleted the drawer-end-fix branch October 28, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: drawer-end cascades for nested drawers
2 participants