Support image input to ellama-instant#334
Open
swapneils wants to merge 1 commit intos-kostyaev:mainfrom
Open
Conversation
Contributor
Author
|
Relatedly, looks like the threshold for FSF copyright assignment is 15 lines? #335 (comment) Per their website (https://www.fsf.org/licensing/assigning.html) the maintainer needs to make a questionnaire to determine eligibility. Could you share that to unblock this PR? |
Owner
|
https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html
|
Owner
|
TODO: add this information to readme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the media API in
llmto support sending multipart inputs (which can contain both text and images) as lists intoellama-instant. It also addsellama-summarize-imageto callellama-summarization-provideron an image file.NOTE: The media API is apparently still alpha quality. I'll leave to your judgement whether this PR should be merged now or wait on
llm's media support stabilizing.