Refactoring some components & adding typescript best practices#123
Open
mth-bou wants to merge 10 commits intos-alad:mainfrom
Open
Refactoring some components & adding typescript best practices#123mth-bou wants to merge 10 commits intos-alad:mainfrom
mth-bou wants to merge 10 commits intos-alad:mainfrom
Conversation
…ewmemories & add parameter into downloadMemories method to use it
Owner
|
Will review sometime soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I've made a few changes to your project. I originally wanted to fix the problem of duplicate memories for the /memories page at each refresh (the table wasn't being reset at each new rendering which added duplicates indefinitely), but I ended up refactoring quite a few things. Here they are:
Refactored the code, improved readability & added stricter typing with Typescript on pages :
I've merged these changes locally and everything works fine.
However, I noticed something strange, which was happening before my changes. When I tried to add a new post today, the post was indeed added and displayed on the BeReal application, but on yesterday's date. However, I noticed that the API response was correct regarding the date and was displaying "2024/06/24". When I try to delete this post via toofake.lol, I get an error 400. I can't delete this post directly from the BeReal API either, there must be a link.