docs/ci: refresh README help; add lint; fix ShellCheck; guard /etc/inittab fallback#292
docs/ci: refresh README help; add lint; fix ShellCheck; guard /etc/inittab fallback#292VerdantE1 wants to merge 3 commits intoryran:masterfrom
Conversation
- Update README minimal help snippet to match current xsos -h output (v0.7.40) - Document local lint commands in CONTRIB.md - Add GitHub Actions workflow to run bash -n and shellcheck (errors only)
Avoid noisy 'No such file or directory' when /etc/inittab is absent by only reading it if present/readable.
|
For commit 2109939:
Why
Changes
|
|
For commit 11cb227:
|
|
Thank you, this looks really good! I'm currently on holiday. I will review this with intention to merge when I get back in Feb. |
Thanks! Enjoy your holiday 😊 |
|
In your docs commit you appear to have removed parsing of the ss and firewall options. Please don't remove those. As you are fixing up that commit anyway, please also don't add the extra whitespace in the bash-completion file. I am not sure why the 4th commit is there. It looks to be just a Merge commit adding the same changes again? If so, there is no need for that commit, just the three commits which make the changes. The other things look okay and ready to merge, good work. (I am not familiar with Gitub CI but the yaml makes sense) |
f7fb32d to
8a8678d
Compare
|
I've updated the PR as requested:
|
For commit f3f166a