Skip to content

[next] attribute without a value should default to true when merged into a spread #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
titoBouzout wants to merge 2 commits into
base: next
Choose a base branch
from
Open

[next] attribute without a value should default to true when merged into a spread #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c559ff5
attribute without a value should default to `true` as opposed to an e…
titoBouzout Nov 2, 2025
d79b937
update tests
titoBouzout Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-plugin-jsx-dom-expressions/src/dom/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,7 @@ function processSpreads(path, attributes, { elem, isSVG, hasChildren, wrapCondit
runningObject.push(
t.objectProperty(
t.stringLiteral(key),
isContainer ? node.value.expression : node.value || t.stringLiteral("")
isContainer ? node.value.expression : node.value || t.booleanLiteral(true)
)
);
}
Expand Down
8 changes: 4 additions & 4 deletions ...lugin-jsx-dom-expressions/test/__dom_compatible_fixtures__/attributeExpressions/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ const template = (() => {
_$spread(
_el$2,
_$mergeProps(results, {
foo: "",
disabled: "",
foo: true,
disabled: true,
get title() {
return welcoming();
},
Expand Down Expand Up @@ -362,7 +362,7 @@ const template24 = (() => {
_$spread(
_el$32,
_$mergeProps(props, {
something: ""
something: true
}),
false,
false
Expand All @@ -376,7 +376,7 @@ const template25 = (() => {
_$spread(
_el$34,
_$mergeProps(props, {
something: ""
something: true
}),
false,
false
Expand Down
8 changes: 4 additions & 4 deletions ...ges/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/attributeExpressions/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ const template = (() => {
_$spread(
_el$2,
_$mergeProps(results, {
foo: "",
disabled: "",
foo: true,
disabled: true,
get title() {
return welcoming();
},
Expand Down Expand Up @@ -350,7 +350,7 @@ const template24 = (() => {
_$spread(
_el$32,
_$mergeProps(props, {
something: ""
something: true
}),
false,
false
Expand All @@ -364,7 +364,7 @@ const template25 = (() => {
_$spread(
_el$34,
_$mergeProps(props, {
something: ""
something: true
}),
false,
false
Expand Down
8 changes: 4 additions & 4 deletions ...lugin-jsx-dom-expressions/test/__dom_hydratable_fixtures__/attributeExpressions/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ const template = (() => {
_$spread(
_el$2,
_$mergeProps(results, {
foo: "",
disabled: "",
foo: true,
disabled: true,
get title() {
return welcoming();
},
Expand Down Expand Up @@ -359,7 +359,7 @@ const template24 = (() => {
_$spread(
_el$32,
_$mergeProps(props, {
something: ""
something: true
}),
false,
false
Expand All @@ -376,7 +376,7 @@ const template25 = (() => {
_$spread(
_el$34,
_$mergeProps(props, {
something: ""
something: true
}),
false,
false
Expand Down
8 changes: 4 additions & 4 deletions ...babel-plugin-jsx-dom-expressions/test/__dynamic_fixtures__/attributeExpressions/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ const template = (() => {
_$spread(
_el$2,
_$mergeProps(results, {
foo: "",
disabled: "",
foo: true,
disabled: true,
get title() {
return welcoming();
},
Expand Down Expand Up @@ -352,7 +352,7 @@ const template24 = (() => {
_$spread(
_el$32,
_$mergeProps(props, {
something: ""
something: true
}),
false,
false
Expand All @@ -366,7 +366,7 @@ const template25 = (() => {
_$spread(
_el$34,
_$mergeProps(props, {
something: ""
something: true
}),
false,
false
Expand Down
Loading