[main] add option inlineStyles to disable style inlining
#470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titoBouzout
changed the title
inlineStyles to disable style inlininginlineStyles to disable style inlining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the discord thread https://discord.com/channels/722131463138705510/932856348855660544/1433828824692555876
It has been raised the issue that with a strong CSP configuration that doesnt allow style inlining, solid will cause CSP errors (as expected with such a configuration).
This PR adds a new config
inlineStylesthat defaults totrueallowing to disable style inlining.It does so by wrapping the style value of the attribute with a iife arrow function. The ouput could possibly be improved, at least doesnt creates aditional mergeProps.
Related note: It would be interesting to see if this could be solved in some way when using SolidStart