Skip to content

[main] handle empty style objects #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
titoBouzout wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[main] handle empty style objects #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/babel-plugin-jsx-dom-expressions/src/ssr/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,9 @@ function transformAttributes(path, results, info) {
t.isObjectExpression(value.expression) &&
!value.expression.properties.some(p => t.isSpreadElement(p))
) {
if (value.expression.properties.length === 0) {
return;
}
const props = value.expression.properties.map((p, i) =>
t.callExpression(registerImportMethod(path, "ssrStyleProperty"), [
t.stringLiteral(
Expand Down
2 changes: 2 additions & 0 deletions packages/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/attributeExpressions/code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,3 +303,5 @@ const template89 = <div style={{"background":"red", "color":"green", "border":nu
}

const template90 = <div data-hk="should warn data-hk is present on template"/>

const template91 = <div style={{}}/>
1 change: 1 addition & 0 deletions ...ges/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/attributeExpressions/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,4 +626,5 @@ const template89 = _tmpl$59();
});
}
const template90 = _tmpl$4();
const template91 = _tmpl$4();
_$delegateEvents(["click", "input"]);
5 changes: 5 additions & 0 deletions packages/babel-plugin-jsx-dom-expressions/test/__ssr_fixtures__/attributeExpressions/code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,3 +245,8 @@ const template51 = (
/>
);

const template52 = (
<div
style={{}}
/>
);
1 change: 1 addition & 0 deletions ...ges/babel-plugin-jsx-dom-expressions/test/__ssr_fixtures__/attributeExpressions/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,3 +310,4 @@ const template49 = _$ssr(_tmpl$27);
const template50 = _$ssr(_tmpl$28);
const nope = () => undefined;
const template51 = _$ssr(_tmpl$29, _$ssrStyleProperty("--bg:", _$escape(nope(), true)));
const template52 = _$ssr(_tmpl$8);
2 changes: 2 additions & 0 deletions ...-plugin-jsx-dom-expressions/test/__ssr_hydratable_fixtures__/attributeExpressions/code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,3 +202,5 @@ const template41 = (
<option value={Color.Blue}>Blue</option>
</select>
);

const template42 = <div style={{ }} />;
1 change: 1 addition & 0 deletions ...lugin-jsx-dom-expressions/test/__ssr_hydratable_fixtures__/attributeExpressions/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,3 +286,4 @@ const template41 = _$ssr(
_$ssrAttribute("value", _$escape(Color.Red, true), false),
_$ssrAttribute("value", _$escape(Color.Blue, true), false)
);
const template42 = _$ssr(_tmpl$8, _$ssrHydrationKey());
Loading