Skip to content

Conversation

@titoBouzout
Copy link
Contributor

I figured that instead of hardcoding node.evalute().confident here and there in random features, we can just sort of preprocess all values of attributes recursively. So any feature wont need to do node.evalute().confident.

Notes:

  • I didnt remove our current usage of node.evalute().confident as to not change the code too much. I would prefer to leave refactoring for once we hit Solid v2.
  • it applies to dom, ssr and universal
  • A curious change is { selected } (when true) becomes { selected: true }, or { id: id } becomes { id: "my-id"} I suppose thats fine
  • attr={object.property} when const object = {property:true} remains unaffected, I suppose this is good as to not mess up object getters. Interesting that doesnt catch it when it comes from a literal (as in this very particular case could have been evvaluated and inlined just fine).

@titoBouzout titoBouzout changed the title use evaluate().confident recursively for all attributes values for dom, ssr and universal [main] use evaluate().confident recursively for all attributes values for dom, ssr and universal Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant