[main] use evaluate().confident recursively for all attributes values for dom, ssr and universal
#467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured that instead of hardcoding
node.evalute().confidenthere and there in random features, we can just sort of preprocess all values of attributes recursively. So any feature wont need to donode.evalute().confident.Notes:
node.evalute().confidentas to not change the code too much. I would prefer to leave refactoring for once we hit Solid v2.{ selected }(when true) becomes{ selected: true }, or{ id: id }becomes{ id: "my-id"}I suppose thats fineattr={object.property}whenconst object = {property:true}remains unaffected, I suppose this is good as to not mess up object getters. Interesting that doesnt catch it when it comes from a literal (as in this very particular case could have been evvaluated and inlined just fine).