Handle the case when we don't want of an app server#62
Open
RaitoBezarius wants to merge 2 commits intoryansmith3136:masterfrom
Open
Handle the case when we don't want of an app server#62RaitoBezarius wants to merge 2 commits intoryansmith3136:masterfrom
RaitoBezarius wants to merge 2 commits intoryansmith3136:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this NGINX buildpack suppose that we always want to use an app server.
Here is another option to disable the app server so that you can run NGINX on Heroku just for static files (useful when you have a React frontend and want to serve the static assets built by Webpack after the build pass of Node.js buildpack).
What do you think? I can, of course, rebase if needed.
I edited two parts of the script which were better according to ShellCheck