Add new option to keep original glyphs as is when adding single-width icons #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the shellcheck CI |
Finii
force-pushed
the
feature/single-with-glyphs-option
branch
from
b29faeb to
7f7a9fd
Compare
|
Rebase on master, force push |
[why]
There are three possible options to specify the Nerd Font Mono generation:
-s
--mono
--use-single-width-glyphs
All the three are handled the same.
In order to add a new long option that also handles glyph width in a "single"
cell manner the fear is that two too similar options will confuse users.
[how]
Just hide the longest form.
Also remove from the readme files.
Need to adapt the install.sh script.
(The option still works but is not 'advertised'.)
Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
feature/single-with-glyphs-option
branch
from
7fc628b to
171ac54
Compare
…uching existing glyphs [why] This can help if you want monospaced icons but not-force the other glyphs to be monospaced (which we do to make the whole font monospace-detectable which was a major issue in the beginning, esp with Windows). [how] Add option --single-width-glyphs that makes the added glyphs single width (like --mono), but leaves preexisting glyphs untouched. Fixes: #1772 Signed-off-by: Fini Jastrow <[email protected]>
[why] This warning turns up with shellcheck 0.9.0, but not with 0.8.0 which we used previously. Signed-off-by: Fini Jastrow <[email protected]>
EXPERIMENTAL [why] Sometimes users want to tweak the cell sizing or the baseline to baseline distance, or the middle point of the cell. [how] Add a new option to show the 'cell' box and to override the detected one. It is not sufficient to adjust width and height, because that can not define shifts of the cell up/down (left/right is mostly useless and I believe the code does not work if the xmin is not zero). The smaller icon-height is not used here (affecting only --mono) because that seems to compilcated right now. Signed-off-by: Fini Jastrow <[email protected]>
[why] I again had to look the reason for the code up, which just looks strange. Who expects that a bool is an instance of int? I certainly not. Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
feature/single-with-glyphs-option
branch
from
171ac54 to
5d7bd1b
Compare
|
Also sneaking in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, if you want to have "monospaces" icons you always also force the font to be monospaced in Windows terms.
That has biten us in the past. Maybe It is better to leave that choice to the user and make this two options.
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
Remove
--use-single-width-glyphs(to avoid confusion)Add
--single-with-glyphswhich is analogous to--variable-with-glyphsand just affects our added icons.The old
-sand--monoforce any font to be strictly monospaced and also sets the newsingle-with-glyphsoption.How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)